January 11th, 2022 | notes | kipras melnikovas

[[git-stacked-rebase]]
- {{[[TODO]]}} account for `drop` commands
  - current work-around - move commits into the end of the latest branch, and then drop them with a regular rebase (or n=2 reset --hard @~n)
- {{[[TODO]]}} something went wrong when re-naming a folder, which ofc later commits got impacted by it - investigate
  - --apply is not being done if no local history hasn't been modified, even though it might've been modified previously. thus the `git-rebase-todo.applied` is not there (just `git-rebase-todo`).
    - {{[[TODO]]}} already discussed about this previously. need to implement proper fixes.
- {{[[TODO]]}} `rewritten-list` doesn't exist if doing regular rebase e.g. `git rebase @~4` - in the post-something script, check if the file exists first
(hidden) tXPsQicQQ
(hidden) 7bEvNFyIs [[export-html-pages]]
- {{[[TODO]]}} (hidden) QY0GmCzHA [[(hidden) BfzxvGFk0]]
- (hidden) HvzrRI3v6
(hidden) jYcOAZAAb
#[[(hidden) S-ygYfi0j]] [[codemods]]
- {{[[TODO]]}} voice notes - prep for demo well-structured demo
  - {{[[DONE]]}} confirm time w/ [[(hidden) tv1zOVzED]]
    - 14:00 TLN
    - {{[[DONE]]}} add into doc so that it's announced
  - {{[[TODO]]}} open demo in vscode
    - pre-write the run cmd (with `x`)
    - or just know we'll run all at once?
  - {{[[TODO]]}} links
    - {{[[TODO]]}} pre-open
    - {{[[TODO]]}} post to slack
    - sharing the links i'll use in the codemods demo in advance: [1] codemods repo - https://github.com/pipedrive/CodeshiftCommunity/tree/fork/community [2] what's new in cui5 - https://cui.pipedrive.tools/v5/?path=/docs/documentation-what-s-new-in-cui-5--page [3] getting started w/ cui5 - https://cui.pipedrive.tools/v5/?path=/docs/documentation-getting-started--page /@pipedrive__convention-ui-react [4] migration-help channel - #migration-help-cui4-to-cui5
    - {{[[TODO]]}} more?
  - record
  - mute pls
  - overview
  - what is a codemod
  - what is it good for
  - what they are not
  - {{[[TODO]]}} small demos to show what's going on
    - do not repeat what's already in the readme
    - showcase different comment levels - info vs warning etc
  - take questions
  - proper demo
    - show codemods repo install process
    - {{[[TODO]]}} have preselected migration repo (library to have cui as standalone)
      - `billing-fe/frontend`
    - (?) install cui5 to see errors
      - mention that [[(hidden) tv1zOVzED]] will elaborate [later](((3-PZ2JF-D))) re: externals
    - run codemods
    - {{[[TODO]]}} have already-ran repo ready to avoid waiting
    - git diff -u -b
    - mention that you'll want to run your linter afterwards
    - give over to [[(hidden) tv1zOVzED]] to explain what else needs to be done when you're migrating
  - take questions
  - ask to try them out & give feedback
    - show migration-help channel
  - ~~a few more small things~~ future plans
    - fork vs separate repo & inner source
    - fe docs
    - knowledge sharing & help on writing your own codemods for your libraries
    - eliminating some of the limitations
  - from chat w/ [[(hidden) pHco5hQZn]]
    - mention fork vs separate repo
      - invite to write your own codemods there, encourage doing them (inform when it makes sense to write codemods) & to reach out because we're welcome to share our konwledge
    - we'll have fe docs
    - do not do intro to internal stuff (baby steps - currently step one)
    - its all marketing
      - standing out, just like which oss lib to use
      - mention what capabilities we'll have in the future
- transform to update the import name to specify the number
  - {{[[TODO]]}} how do i tell ppl to upgrade?
    - for services (non-libraries), update the external in the webpack config
    - for libraries, you'll likely need to update to the
    - [[(hidden) tv1zOVzED]] will take care of this part
  - not now
    - {{[[TODO]]}} if [[(hidden) tv1zOVzED]] confirms we need the versioned import, then write a simple, separate codemod to rename them
  - quick info card service?
    - hmm. yes, sure. but changes are pretty random if you go thru them.
    - i think instead we should start with the individual demo's
      - to showcase the different capabilities, edge cases if e.g. a value is missing (warning), limitations, etc.
      - and only then do the full demo, and then [[(hidden) tv1zOVzED]] can jump in
- thinking now about quickly implementing the graph-aware stuff lmao
  - {{[[TODO]]}} not that, but extract each transform into a separate codemod that you can run, and give it a name in [[(hidden) yfSgFo2gF]], and showcase that you can run individually
    - while still ofc keeping the group of codemods available as just `cui5`
    - (!) this is good because if we ship `alpha` (experimental) codemods, then we can put them as `cui5-alpha-` - people will now know that you can run them separately
  - okay now i wrote this out (how i'd have to implement it) and there's no way i can do it before the demo, so let's not do anything with it before we do the demo, just like it should've been.
    - good decision. would've been a big mistake lmao
- observation:: when you're preparing for a [[demo]], stuff becomes very clear quite fast lol
- {{[[DONE]]}} ((5ssdrAtcf)) 1/2
  - {{[[DONE]]}} fix commits
  - {{[[DONE]]}} move `wip-transforms` into `transforms`
  - {{[[DONE]]}} move `src/5.0.0/_boilerplate` into `src/boilerplate`
  - {{[[DONE]]}} add Meta to readme
  - not now
    - {{[[TODO]]}} merge 2/2
      - {{[[TODO]]}} clean up postcss transform (dir, layout, names etc)
      - {{[[TODO]]}} try out on actual .postcss/.scss before (at least for [[(hidden) tv1zOVzED]]'s PR)
      - {{[[TODO]]}} extend [[(hidden) tv1zOVzED]]'s css codemod to remove the no longer needed css imports
        
        (hidden) AV7J4zqkD:: https://github.com/pipedrive/archive/blob/995f90e0bf2d86aa1b7c3a2b2d02df5cfad71d37/fe-onboarding-presentation/src/css/main.postcss#[[(hidden) WBl6TSRcS]]1-L2
- {{[[DONE]]}} investigate reported issue by [[(hidden) 04oQOtp3e]]
  - https://pipedrive.slack.com/archives/C02LK8Y583D/p1641914908004100?thread_ts=1641893745.002800&cid=C02LK8Y583D
  - https://github.com/pipedrive/docbase-ui
    - `client/`
  - mitigated for the time being - can run codemods again, but now with the `tsx` parser
    - documented: https://github.com/pipedrive/CodeshiftCommunity/blob/d88722f1377745310ead0fb48e03f958110903eb/community/@pipedrive__convention-ui-react/README.md#[[(hidden) WBl6TSRcS]]137
  - {{[[TODO]]}} will later need to investigate parsers #[[(hidden) XEbAy1sYy]]
    - https://pipedrive.atlassian.net/browse/FUN-2074
      - had a report of an error [1], which came down to the flow parser [2]. looks like ideally we’d use the tsx parser, which jscodeshift just abstracts over the babylon (@babel/parser) with some predefined options. [3] the problem was that jscodeshift with the tsx parser & it’s options does not consider require as an import statement, and then most codemods become useless if you’re using requires. [4] (there might be other draw-backs as well, just haven’t investigated deep enough). [1] https://pipedrive.slack.com/archives/C02LK8Y583D/p1641893745002800 [2] https://pipedrive.slack.com/archives/C02LK8Y583D/p1641923713004400?thread_ts=1641893745.002800&cid=C02LK8Y583D [3] https://github.com/facebook/jscodeshift/blob/main/parser/tsx.js [4] https://pipedrive.slack.com/archives/C02LK8Y583D/p1641925900005500?thread_ts=1641893745.002800&cid=C02LK8Y583D
- {{[[DONE]]}} another issue after updating (merging upstream) (i think) - if there's an error e.g. typescript fails to compile, the codemod run fails silently, w/o reporting the error #[[(hidden) YU9N4LSCL]]
  - wait wtf why does it not work again
    - roflmao the commit that added the call to run postcss codemods in run.js - was in the latest branch, which was the not-yet-merged one. #[[(hidden) Ux6tvluwa]]
      - wait wtf, that's for .postcss/.scss files. no need for css in js. misery continues
        
        {{[[DONE]]}} OH MY GOD IT'S THE EMPTY-ARRAY OF CONFIGS FOR THE TRANSFORM #[[(hidden) Ux6tvluwa]] #[[(hidden) Ux6tvluwa]] #[[(hidden) Ux6tvluwa]]
- ((Ty_dCgL4d))
  - on development - focus on maintenance / extracting into separate repo, instead of shipping new features
    - also especially focus on getting the PRs merged into upstream, because they'll be blockers later
    - {{[[TODO]]}} setup [[(hidden) 9y6zKCUgH]], when we have our own repo
  - (hidden) ExsFnreoj #[[(hidden) 7c2C8PgIV]]
    - (hidden) kWZf6mnoE [[(hidden) pHco5hQZn]] [[(hidden) 01-27-2022]] [[(hidden) qtEMrD1aX]] [[(hidden) s1p7372Kx]]
    - {{[[TODO]]}} (hidden) eP-fS7XTX [[(hidden) lMFcxU-Op]]
(hidden) 6nOn_JFm4
(hidden) ZfV8LHIHn
(hidden) KYtMJsUrm
(hidden) acUSBFzcM
(hidden) 1Sf5N_VUP

words:	1090 + 19 = 1109
last update: